[codex] Phase 3F: safe web runtime fixes#16
Merged
Conversation
Co-authored-by: Codex <codex@openai.com> (cherry picked from commit 3083d71)
Co-authored-by: Codex <codex@openai.com> (cherry picked from commit 8919ae7)
Co-authored-by: Codex <codex@openai.com> (cherry picked from commit 8b993bc)
Co-authored-by: Codex <codex@openai.com> (cherry picked from commit 4abf8b4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 3F applies a small set of web-safe upstream runtime fixes before the larger Phase 4 preview/browser-simulation work:
Intentionally deferred from this phase
c1e2408e1/ browserTargetResolver preview-host handling: deferred with browser/preview simulation work because this fork does not have that resolver path.ea52bb1dbtrace ID clipboard UI: not directly portable because current saved-backend runtime state has no traceId field.c6c64918fChatMarkdown rerender reduction: overlaps a larger markdown chrome/table-copy refactor and should be handled with the UI phase instead of this small runtime-fix PR.28107e89cdiff component rename cleanup: obsolete in this fork; the old active path is already gone.Grok Composer 2.5 review
Reviewed with
grok -m grok-composer-2.5-fastafter implementation and again after removing no-op DPoP commits from the branch.Final verdict: approve, no merge-blocking issues.
Verification
vp test apps/server/src/provider/Layers/CursorProvider.test.ts packages/shared/src/remote.test.ts packages/client-runtime/src/shellSnapshotReducer.test.ts— 41 passedvp run typecheck— passedsrc/diagnostics/ProcessResourceMonitor.ts(315,5)vp check— passedreact(no-unstable-nested-components)warnings remain